sam/Quill
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Protecting better against undefined properties

Browse Source
This commit is contained in:
metacryst
2024-04-01 15:14:14 -05:00
parent bf3650ef6a
commit 6a33126563
5 changed files with 82 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
Test/init.test.js
View File

@@ -171,6 +171,25 @@ window.testSuites.push( class testInit {
} }
} }
CannotAddUndefinedPropertiesAfterDefaultConstructor() {
register(class File extends Shadow {
render = () => {
p("boi")
}
}, randomName("file"))
try {
const file = File()
file.hey = "unallowed"
return "Did not throw error!"
} catch(e) {
if(!e.message.includes("extensible")) {
throw e
}
}
}
NonStateFieldsGetSet() { NonStateFieldsGetSet() {
register(class File extends Shadow { register(class File extends Shadow {
nonStateField nonStateField

8
Test/observedobject.test.js
View File

@@ -26,6 +26,14 @@ window.testSuites.push( class testObservedObject {
} }
} }
ConstructorWorks() {
return "not done"
}
NotExtensible() {
return "not done"
}
// MustInitAllFields() { // MustInitAllFields() {
// class Form extends ObservedObject { // class Form extends ObservedObject {
// id // id

2
Test/test.html
View File

@@ -14,7 +14,7 @@
} }
</script> </script>
</head> </head>
<body> <body style="background: rgb(242, 194, 147)">
</body> </body>
</html> </html>

2
Test/test.js
View File

@@ -3,8 +3,8 @@ window.testSuites = [];
await import ("./parse.test.js") await import ("./parse.test.js")
await import ("./init.test.js") await import ("./init.test.js")
await import ("./observedobject.test.js")
await import ("./render.test.js") await import ("./render.test.js")
await import ("./observedobject.test.js")
window.randomName = function randomName(prefix) { window.randomName = function randomName(prefix) {
const sanitizedPrefix = prefix.toLowerCase().replace(/[^a-z0-9]/g, ''); const sanitizedPrefix = prefix.toLowerCase().replace(/[^a-z0-9]/g, '');

72
index.js
View File

@@ -550,7 +550,7 @@ window.Registry = class Registry {
if (constructorFound && trimmedLine.startsWith('super(') && !superCallFound) { if (constructorFound && trimmedLine.startsWith('super(') && !superCallFound) {
superCallFound = true; superCallFound = true;
modifiedLines.push(` window.Registry.construct(this, window.Registry.currentStateVariables, ...window.Registry.currentParams);`); modifiedLines.push(` window.Registry.construct(this);`);
} }
if (constructorFound && braceDepth === 1 && superCallFound && !constructorEndFound) { if (constructorFound && braceDepth === 1 && superCallFound && !constructorEndFound) {
@@ -574,11 +574,13 @@ window.Registry = class Registry {
constructor(...params) { constructor(...params) {
super(...params) super(...params)
window.Registry.construct(this) window.Registry.construct(this)
Object.preventExtensions(this);
window.Registry.testInitialized(this);
} }
` `
let closingBracket = str.lastIndexOf("}"); let closingBracket = str.lastIndexOf("}");
str = str.slice(0, closingBracket - 1) + constructorString + "\n}" str = str.slice(0, closingBracket - 1) + constructorString + "\n}"
return eval('(' + str + ')'); return eval('(' + str + `) //# sourceURL=${classObject.prototype.constructor.name}.shadow`);
} }
} }
} }
@@ -619,7 +621,7 @@ window.p = function p(innerText) {
window.div = function (innerText) { window.div = function (innerText) {
let div = document.createElement("div") let div = document.createElement("div")
div.innerText = innerText div.innerText = innerText ?? ""
Registry.render(div) Registry.render(div)
return div return div
} }
@@ -646,6 +648,19 @@ window.VStack = function (cb = () => {}) {
} }
} }
window.HStack = function (cb = () => {}) {
let nowRendering = window.rendering.last()
if(nowRendering.innerHTML === "") {
let styles = `
display: flex;
flex-direction: row;
`
quillStyles.update(nowRendering.tagName.toLowerCase(), styles)
cb()
return nowRendering
}
}
/* SHAPES */ /* SHAPES */
window.Circle = function(text = "") { window.Circle = function(text = "") {
@@ -746,6 +761,41 @@ HTMLElement.prototype.height = function(value, unit = "px") {
return this return this
} }
function checkStyle(el) {
let computed = window.getComputedStyle(el).position
if(!(computed === "absolute" || computed === "fixed")) {
el.style.position = "absolute"
}
}
HTMLElement.prototype.x = function(value, unit = "px") {
checkStyle(this)
this.style.left = value + unit
Registry.initReactivity(this, ["style", "left"], value);
return this
}
HTMLElement.prototype.y = function(value, unit = "px") {
checkStyle(this)
this.style.top = value + unit
Registry.initReactivity(this, ["style", "top"], value);
return this
}
HTMLElement.prototype.xRight = function(value, unit = "px") {
checkStyle(this)
this.style.right = value + unit
Registry.initReactivity(this, ["style", "right"], value);
return this
}
HTMLElement.prototype.yBottom = function(value, unit = "px") {
checkStyle(this)
this.style.bottom = value + unit
Registry.initReactivity(this, ["style", "bottom"], value);
return this
}
HTMLElement.prototype.margin = function(direction, value) { HTMLElement.prototype.margin = function(direction, value) {
const directionName = `margin${direction.charAt(0).toUpperCase()}${direction.slice(1)}`; const directionName = `margin${direction.charAt(0).toUpperCase()}${direction.slice(1)}`;
if (typeof value === 'number') { if (typeof value === 'number') {
@@ -767,22 +817,6 @@ HTMLElement.prototype.positionType = function (value) {
return this return this
} }
HTMLElement.prototype.position = function({x, y} = {}) {
if(!(typeof x === 'number') || !(typeof x === 'number')) {
console.error("HTMLElement.position: must have valid x and y values: {x: 12, y: 23} where x and y are percentages")
return;
}
let computed = window.getComputedStyle(this).position
if(!(computed === "absolute" || computed === "fixed")) {
this.style.position = "absolute"
}
this.style.left = `${x}%`
this.style.top = `${y}%`
Registry.initReactivity(this, ["style", "top"], y);
Registry.initReactivity(this, ["style", "left"], x);
return this
}
/* PROTOTYPE EVENTS */ /* PROTOTYPE EVENTS */
HTMLElement.prototype.onClick = function(func) { HTMLElement.prototype.onClick = function(func) {